Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add orangepi zero3 #37

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat: add orangepi zero3 #37

merged 2 commits into from
Nov 1, 2023

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Oct 22, 2023

No description provided.

@meteyou
feat: add orangepi zero3
002029e 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou mentioned this pull request Oct 22, 2023
Open
@meteyou
fix: add MEM_TYPE to opi zero3
4774005 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested a review from KwadFan October 28, 2023 09:15
KwadFan
KwadFan approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@KwadFan KwadFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KwadFan KwadFan mentioned this pull request Oct 28, 2023
Open
KwadFan
KwadFan requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@KwadFan KwadFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I realized it latly, it is missing our needed FAT32 Boot partition...

@meteyou
Copy link
Member Author

meteyou commented Oct 28, 2023

i didn't change this option. this should have it as the zero2 image...

@KwadFan
Copy link
Member

KwadFan commented Oct 28, 2023

Ok, have to figure out, why it is missing...

KwadFan
KwadFan approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@KwadFan KwadFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I cant tell what was wrong on my end but it seems the resulting image is correct.

@meteyou meteyou merged commit aefb271 into master Nov 1, 2023
23 checks passed
@meteyou meteyou deleted the chore/add-orangepizero3 branch November 1, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KwadFan KwadFan KwadFan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteyou @KwadFan