Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extend css editor support to .scss and .sass files #1083

Conversation

Henlor
Copy link
Contributor

@Henlor Henlor commented Sep 15, 2022

This PR will fix [FR] #1082

Signed-off-by: Kevin Lemarchand lem.kev@gmail.com

@dw-0
Copy link
Member

dw-0 commented Sep 15, 2022

Hi, thanks for the PR. Fyi, the sign-off requires to contain your real name as per our contribution guideline.

https://github.com/mainsail-crew/mainsail/blob/develop/CONTRIBUTING.md#-submitting-a-pull-request-pr

@Henlor
Copy link
Contributor Author

Henlor commented Sep 15, 2022

Hi, thanks for the PR. Fyi, the sign-off requires to contain your real name as per our contribution guideline.

https://github.com/mainsail-crew/mainsail/blob/develop/CONTRIBUTING.md#-submitting-a-pull-request-pr

It's updated, sorry for that ;)

@meteyou meteyou changed the title improve: Extend css language support to .scss and .sass extension files refactor: Extend css language support to .scss and .sass extension files Sep 16, 2022
@dw-0 dw-0 linked an issue Sep 16, 2022 that may be closed by this pull request
@meteyou meteyou changed the title refactor: Extend css language support to .scss and .sass extension files refactor: extend css editor support to .scss and .sass files Sep 16, 2022
@meteyou meteyou merged commit e411175 into mainsail-crew:develop Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Extend css language support to scss files.
3 participants