Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add different color maps for heightmap #1666

Merged
merged 9 commits into from
Nov 28, 2023

Conversation

DustSwiffer
Copy link
Contributor

Description

Added new feature so the end-user is able to switch from colormaps for the heightmap through the settings menu.

Related Tickets & Documents

There was none. discussed though Discord.

Mobile & Desktop Screenshots/Recordings

pc.and.translations.mp4
phone.mp4

[optional] Are there any post-deployment tasks we need to perform?

So far i know i have nothing done which needs post-deployment.

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
nl.json 123 7

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
nl.json 123 7

@DustSwiffer DustSwiffer changed the title Different color maps for heightmaps Feat: Different color maps for heightmaps Nov 26, 2023
@meteyou meteyou changed the title Feat: Different color maps for heightmaps feat: add different color maps for heightmap Nov 26, 2023
src/components/TheSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsHeightmapTab.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsHeightmapTab.vue Outdated Show resolved Hide resolved
src/components/settings/SettingsHeightmapTab.vue Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/nl.json Outdated Show resolved Hide resolved
src/pages/Heightmap.vue Outdated Show resolved Hide resolved
src/store/index.ts Outdated Show resolved Hide resolved
@meteyou
Copy link
Member

meteyou commented Nov 26, 2023

i only found a few small issues. if these are fixed, i can merge the PR. thanks a lot for your work!

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 1 0
nl.json 124 7

@DustSwiffer
Copy link
Contributor Author

i only found a few small issues. if these are fixed, i can merge the PR. thanks a lot for your work!

no problem at all :)
i think its a feature a lot of people will like

@DustSwiffer DustSwiffer requested a review from meteyou November 28, 2023 11:39
@meteyou
Copy link
Member

meteyou commented Nov 28, 2023

in one file you forgot to rename "Navigation" to "Heightmap". the rest looks good to me!

@DustSwiffer
Copy link
Contributor Author

in one file you forgot to rename "Navigation" to "Heightmap". the rest looks good to me!

fudge let me fix it asap

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
nl.json 123 7

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
nl.json 123 7

Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 0
nl.json 123 7

@meteyou meteyou merged commit 98ebeef into mainsail-crew:develop Nov 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants