fix: incorrect scaling of images in dialogImage #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the squishing of big images in the config file preview window. Scales image down while preserving the original aspect ratio. Signed-off-by: Simion Balanuta <contact@cybersnets.com>
meteyou
approved these changes
Jan 14, 2024
|
Thx for your PR! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the squishing of big images in the config file preview window, now it will properly scale down the images while preserving the original aspect ratio instead of trying to make them fit by squishing them down.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Original:
After the fix:
[optional] Are there any post-deployment tasks we need to perform?