refactor: refactor code in Gcodefiles.vue #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
…IDE warnings Signed-off-by: Dominik Willner <th33xitus@gmail.com>
removes redundant conditionals and simplifies the code Signed-off-by: Dominik Willner <th33xitus@gmail.com>
`Argument type {filename: string, permissions: string, modified: Date} is not assignable to parameter type FileStateGcodefile`
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
use an already declared interface as value instead of defining the full item object over again. Signed-off-by: Dominik Willner <th33xitus@gmail.com>
use the `disabled` prop of v-tooltip to check for the existence of a big thumbnail saves duplicated template code Signed-off-by: Dominik Willner <th33xitus@gmail.com>
dw-0
changed the title
|
Language file analysis report:
|
dw-0
force-pushed
the
tweak-gcodefiles
branch
2 times, most recently
from
22eb4d6 to
06d4f7b
Compare
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
…iles getter Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
meteyou
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the overall code of the Gcodefiles.vue file.
altattribute which the IDE complained with a warning about, they now have that attribute with a proper descriptionslotwas marked as deprecated by the IDE onv-progress-circularandv-icon. referring to the vuetify docs, those elements don't have a slot atttribute. thevue-load-imagecomponent in turn requires those slots with specific names to function properly. the solution was to simply wrap divs with the proper slot attributes aroundv-progress-circularandv-iconpreheat()was improved. several conditions were considered as redundant. the control mixin was imported to make use of thedoSend()method making the code even easier to read and maintainArgument type {filename: string, permissions: string, modified: Date} is not assignable to parameter type FileStateGcodefilewere fixed with proper type definitionsitemobject incontextMenuanddialogRenameFilewas redefined asitem: this.dialogFile. getting rid of the previously mentioned warnings and redundant codedisabledproperty ofv-tooltipand checking for existence of a big thumbnail there helps us getting rid of duplicated template codeSigned-off-by: Dominik Willner th33xitus@gmail.com