-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAISTRA-2648: WASM fix for s390x [maistra-2.2] #139
Conversation
Fixes https://issues.redhat.com/browse/MAISTRA-2648 The permanent fix is not a part of maistra/envoy yet: proxy-wasm/proxy-wasm-cpp-host#198 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Hi @knm3000. Thanks for your PR. I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix stops an existing test failing on s390x https://github.com/maistra/header-append-filter/blob/maistra-2.2/tests/run-envoy.sh#L34 |
This reverts commit e5f9fab. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Fixes https://issues.redhat.com/browse/MAISTRA-2648 The permanent fix is not a part of maistra/envoy yet: proxy-wasm/proxy-wasm-cpp-host#198 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198
Signed-off-by: Konstantin Maksimov konstantin.maksimov@ibm.com