Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAISTRA-2648: WASM fix for s390x [maistra-2.2] #139

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

knm3000
Copy link
Contributor

@knm3000 knm3000 commented Mar 10, 2022

Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198

Signed-off-by: Konstantin Maksimov konstantin.maksimov@ibm.com

Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198

Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
@maistra-bot
Copy link

Hi @knm3000. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knm3000 knm3000 changed the title MAISTRA-2648: WASM fix for s390x MAISTRA-2648: WASM fix for s390x [maistra-2.2] Mar 10, 2022
@oschaaf oschaaf requested review from twghu and jwendell March 10, 2022 22:05
Copy link
Contributor

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but deferring to @twghu and @jwendell for final review to avoid collisions with any in-flight work they might have. Therefore I added the do-not-merge/hold label to avoid auto-merge upon this approval.

@twghu
Copy link
Contributor

twghu commented Mar 14, 2022

This fix stops an existing test failing on s390x https://github.com/maistra/header-append-filter/blob/maistra-2.2/tests/run-envoy.sh#L34

@maistra-bot maistra-bot merged commit e5f9fab into maistra:maistra-2.2 Mar 17, 2022
oschaaf pushed a commit to oschaaf/envoy-maistra that referenced this pull request Mar 28, 2022
This reverts commit e5f9fab.

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
maistra-bot pushed a commit that referenced this pull request Mar 28, 2022
This reverts commit e5f9fab.

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
oschaaf pushed a commit to oschaaf/envoy-maistra that referenced this pull request Apr 11, 2022
…tra#149)"

This reverts commit d5e17b5.

Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
@knm3000 knm3000 deleted the wasm-on-s390x-2.2 branch June 2, 2022 12:30
dcillera pushed a commit to dcillera/envoy that referenced this pull request Feb 19, 2024
Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198

Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants