Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSSM-8136] Add Kiali version into kiali cr + improve stability of TestOpenShiftMonitoring test #740

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mkralik3
Copy link
Collaborator

@mkralik3 mkralik3 commented Sep 13, 2024

  • Added Kiali version to the Kiali CR to not install the same version as the operator version ( since now, it is 1.89 operator version )
  • Added waiting for Prometheus target to be ready before requesting the mesh app.

Passed on all SMCP versions: https://master-jenkins-csb-servicemesh.apps.ocp-c1.prod.psi.redhat.com/job/maistra/job/maistra-test-tool/2769/

Copy link

openshift-ci bot commented Sep 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/S label Sep 13, 2024
@mkralik3 mkralik3 force-pushed the kialiFix branch 2 times, most recently from 26ef902 to 2ee2e57 Compare September 13, 2024 09:45
@openshift-ci openshift-ci bot added size/M and removed size/S labels Sep 13, 2024
@mkralik3 mkralik3 changed the title [OSSM-8102] Add kiali version to the standalone Kiali CR [OSSM-8136] Refactor TestOpenShiftMonitoring test to not use standalone Kiali CR Sep 13, 2024
@mkralik3 mkralik3 force-pushed the kialiFix branch 2 times, most recently from 2324c51 to 287968e Compare September 16, 2024 11:38
@openshift-ci openshift-ci bot added size/L and removed size/M labels Sep 16, 2024
@mkralik3 mkralik3 marked this pull request as ready for review September 16, 2024 12:05
@mkralik3 mkralik3 requested a review from jewertow September 16, 2024 12:05
@mkralik3 mkralik3 changed the title [OSSM-8136] Refactor TestOpenShiftMonitoring test to not use standalone Kiali CR [OSSM-8136] Refactor TestOpenShiftMonitoring test to not use standalone Kiali CR + fix flakiness Sep 16, 2024
@jewertow
Copy link
Member

not use standalon kiali CR but patch the existing one (managed by maistra operator) instead. (the way how the customer should use it)

You are not correct saying that customers should not use custom Kiali CR. SMCP intentionally allows to "attach" custom Kiali CR to SMCP. I see 2 reasons to keep custom Kiali as is:

  1. We documented this approach.
  2. OSSM 3 does not support Kiali out of the box and attaching custom Kiali is the way to integrate with OSSM 3, and users migrating to that version have to follow this approach.

@mkralik3
Copy link
Collaborator Author

mkralik3 commented Sep 17, 2024

@jewertow yeah, you are right, the mention is here https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html-single/service_mesh/index#ossm-smcp-kiali_kiali-config-ref , my bad ( I thought that only istio operator should manage kiali, also that was told me on kiali slack )

I will rewrite the test back to use kiali version explicitly to fix the issue.

@mkralik3 mkralik3 marked this pull request as draft September 17, 2024 08:45
@mkralik3 mkralik3 changed the title [OSSM-8136] Refactor TestOpenShiftMonitoring test to not use standalone Kiali CR + fix flakiness [OSSM-8136] Add Kiali version into kiali cr + improve stability of TestOpenShiftMonitoring test Sep 17, 2024
@openshift-ci openshift-ci bot added size/M and removed size/L labels Sep 17, 2024
@mkralik3
Copy link
Collaborator Author

Updated description and the code

@openshift-merge-bot openshift-merge-bot bot merged commit e5c249a into maistra:main Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants