Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermediate certs may work with SNICallback #29

Closed
tracend opened this issue Jun 22, 2019 · 1 comment
Closed

Intermediate certs may work with SNICallback #29

tracend opened this issue Jun 22, 2019 · 1 comment

Comments

@tracend
Copy link
Member

tracend commented Jun 22, 2019

Referencing an old issue:
nodejs/node#2772

For backwards compatibility (and to take the safest route) it may be better to bundle the CA chain with the main cert instead of passing them in their own 'ca' key:

creds.cert += '\n'+ creds.ca;
tracend added a commit that referenced this issue Jun 22, 2019
@tracend
#29: Intermediate certs may work with SNICallback
c7fd514
@tracend
Copy link
Member Author

tracend commented Jun 22, 2019

Closing as addressed.

@tracend tracend closed this as completed Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tracend