Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bookmarks modal not closing on ESC #173

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

objectliteral
Copy link
Contributor

No description provided.

@makew0rld
Copy link
Owner

Thanks! I didn't think of this, but it's handy. Could you add this for other modals too? And update help.go as well to note that Esc will exit modals.

Self-note: Update wiki about this as well.

@objectliteral
Copy link
Contributor Author

AFAICT all the other modals already close on ESC. I tested it specifically for the Subscription and Input modal. The code for the other modals also seems like they should close.

Note added to help.go as well.

@makew0rld makew0rld merged commit 972cb36 into makew0rld:master Feb 4, 2021
@makew0rld
Copy link
Owner

Thanks!

makew0rld added a commit that referenced this pull request Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants