✨Add option to open unknown URLs

[sotpapathe]

A new config option that sets a command to open unsupported URL schemes (e.g. gopher://). It is unset by default to keep the previous behavior.

[makew0rld]

Thanks for this PR, it looks well done. My issue is that an unknown URL could be anything, and so having just one command for it isn't really portable. It could be any number of schemes: gopher://, ipfs://, magnet:, etc. Perhaps using xdg-open is the solution? I'm not sure, as that's often harder to configure.

[sotpapathe]

It allows the user to at least specify another program that will handle unknown schemes, like xdg-open or pso.

I guess the better approach would be to have a dictionary of scheme-program in the configuration, although I don't know how to implement that in go yet.

[sotpapathe]

OK, I've got a better suggestion. The config file will look like this:

[url_handlers]
http = "xdg-open"
gopher = "off"
ftp = "off"
# and any other URL schemes the user desires.
other = "xdg-open"

Then in handleURL(), if the scheme is not gemini, we'll do a viper.GetString("url_handlers." + scheme). If a value is found, it's used as the program to open the URL with. Otherwise the value in "url_handlers.other" is used as the program to open the URL with.

If this sounds good I think I can implement it in the next days.

[makew0rld]

That sounds great! Good idea. I think we can leave the HTTP setting in a-general for compatibility though.

[makew0rld]

Make sure to update default-config.toml as well as default.go. I tend to edit the TOML first, then run go generate ./....

[sotpapathe]

Thanks for the tip, will do!

[sotpapathe]

Updated as discussed and tested with Gopher URLs. I didn't know of any pages with other kinds of URLs but it should work for all schemes.

[makew0rld]

This is a great feature, thanks! See my comments below, I will merge soon.

[makew0rld]

Looks good now, thanks. I will merge soon, after my current linting fixes, like with the other PR. Also I'd appreciate if you didn't force-push for any future PRs, as it makes it impossible to see the diffs as you update things.

Thanks for your interest in Amfora!

[sotpapathe]

Sorry for the force pushes, won't do it again 😃

And thanks for making Amfora!