Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaflet 1.x Support. #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ npm run deploy # deploy to gh-pages
Changelog
-----

### 1.1.1
Add Leaflet 1.x support

### 1.1.0
Update export and extend system

Expand Down
4 changes: 2 additions & 2 deletions example/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<title>Leaflet.Spin</title>
<link rel="stylesheet" href="leaflet/dist/leaflet.css">
<script src="leaflet/dist/leaflet.js" charset="utf-8"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As example should be working without node_modules available (to work in Github Page, you can't use Leaflet from dependencies.

So the solution is, for the example page, calling Leaflet from a CDN (as I've done here: makinacorpus/Leaflet.MeasureControl@fac37b2).

<link rel="stylesheet" href="../node_modules/leaflet/dist/leaflet.css">
<script src="../node_modules/leaflet/dist/leaflet.js" charset="utf-8"></script>
<script src="spin/dist/spin.min.js" charset="utf-8"></script>
<script src="leaflet.spin.min.js" charset="utf-8"></script>
<style type='text/css'>
Expand Down
2 changes: 1 addition & 1 deletion example/leaflet.spin.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 0 additions & 9 deletions example/leaflet/.npmignore

This file was deleted.

27 changes: 0 additions & 27 deletions example/leaflet/.travis.yml

This file was deleted.

957 changes: 0 additions & 957 deletions example/leaflet/CHANGELOG.md

This file was deleted.

155 changes: 0 additions & 155 deletions example/leaflet/CONTRIBUTING.md

This file was deleted.

138 changes: 0 additions & 138 deletions example/leaflet/FAQ.md

This file was deleted.

Loading