Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanent crash when endDisplay is dispatched both for TableDirector and CollectionDirector #33

Closed
andriigua opened this issue Aug 20, 2019 · 0 comments
Closed

Permanent crash when endDisplay is dispatched both for TableDirector and CollectionDirector #33

andriigua opened this issue Aug 20, 2019 · 0 comments
Assignees
@malcommac
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@andriigua
Copy link

I am trying to use endDisplay subscription on CollectionCellAdapter for tracking when my cell is moving from visible area, but unfortunately it permanently crashes as the item is not found in cachedItems collection inside OwlKit. I don't know why but for didEndDisplaying was chosen to use cachedContext method instead of context one which is used for all the other similar callbacks.

Can you give me any clues how I can workaround this?

P.S. no code snippets as this is a permanent crash that can be reproduced all the times when you add subscription for endDisplay
malcommac added a commit that referenced this issue Sep 15, 2019
@malcommac
#33 Removed cachedContext in TableDirector, avoid crash on didEndDisp…
bf6c9d7 
…lay or when accessing to removed items, minor optimizations
malcommac added a commit that referenced this issue Sep 15, 2019
@malcommac
#33 Removed cachedContext from CollectionDirector
a1a51c7
@malcommac malcommac changed the title permanent crash on endDisplay Permanent crash when endDisplay is dispatched both for TableDirector and CollectionDirector Sep 15, 2019
@malcommac malcommac self-assigned this Sep 15, 2019
@malcommac malcommac added the bug Something isn't working label Sep 15, 2019
@malcommac malcommac added this to the 1.1.0 milestone Sep 15, 2019
malcommac added a commit that referenced this issue Sep 15, 2019
@malcommac
#33 Cleanup
7a88b5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malcommac malcommac

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@malcommac @andriigua