Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for invalid indexPath to avoid crashes #35

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Check for invalid indexPath to avoid crashes #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Sources/Collection/CollectionDirector.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,9 @@ open class CollectionDirector: NSObject,
/// - indexPath: index path.
/// - Returns: adapter if any
internal func adapterForHeaderFooter(_ kind: String, indexPath: IndexPath) -> CollectionHeaderFooterAdapterProtocol? {
guard indexPath.section >= 0, indexPath.section < sections.count else {
return nil
}
let adapter: CollectionHeaderFooterAdapterProtocol?
switch kind {
case UICollectionView.elementKindSectionHeader:
Expand Down Expand Up @@ -516,6 +519,9 @@ public extension CollectionDirector {
}

func headerFooterForSection(ofType type: String, at indexPath: IndexPath) -> CollectionHeaderFooterAdapterProtocol? {
guard indexPath.section >= 0, indexPath.section < sections.count else {
return nil
}
switch type {
case UICollectionView.elementKindSectionHeader:
return sections[indexPath.section].headerView
Expand Down