Fix issue where BQ refused to generate "complex SQL" for a select #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I, Christopher Swenson <cswenson@meta.com>, hereby add my Signed-off-by to this commit: 1a137f5 Signed-off-by: Christopher Swenson <cswenson@meta.com>
I, Christopher Swenson <crswenson@google.com>, hereby add my Signed-off-by to this commit: 1a137f5 Signed-off-by: Christopher Swenson <crswenson@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1604
Removed an error-checking condition in the compiler where if "complex SQL" was ever generated for a
selectit would throw an error. This was probably once reasonable when the only way you could generate complex SQL was when there were nests, but now it can also happen if you use window functions.