Extend wrapDef to def and overdef #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtoy-googly-moogly
added a commit
that referenced
this pull request
Dec 21, 2024
* make wrapDef a util * move repeat out of standard library * cleanup wrapDef a little more * even more wrapDef cleanup * fix oopsie * maybe cleaner still? * fix find/replace mistake * rename arg * make all param names into strings * fix trino reverse * moved todos to docs issue * remove extra test for % operator * put the cast back into trino reverse * go ahead and test reverse for arrays on presto * try again to get reverse with generic correct * shared string_reverse * maybe finally fix reverse? * use defwrap to cleanup some errors * another minor code tweak to wrapDef * -cleverness, +readability * add comment * comment edit * comment explaining dialect split * fix T comment * Extend wrapDef to def and overdef (#2060) * experiment with overdef * fix overdef() * mark bitwise_aggs as symmetric * move all the hll functiosn to ... def * make preto-only all def() * delete overdef * stop using def for hll functions * fix presto funcs * cleanup sequence()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.