-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvment on how to build from source #3217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, there are two sections that I don't think should be added for the sake of brevity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole file should not be commited, we should add it to the .gitignore
, sorry for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I see. I did not pay attention to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer that we ensure a clean up after running the tests rather than polluting the .gitignore file.
@ZHG2017 could you rebase and remove the |
It seems you have completely removed it. I meant remove any change so that there is no diff in this PR, sorry for the misunderstanding. You can achieve this with git checkout main -- micromamba/tests/channel_a/linux-64/repodata.json
git add micromamba/tests/channel_a/linux-64/repodata.json
git commit -m "Reset repodata test file" |
Having put a bit more details on how to build from source either as a developer or as a user