Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvment on how to build from source #3217

Closed
wants to merge 0 commits into from
Closed

Improvment on how to build from source #3217

wants to merge 0 commits into from

Conversation

ZHG2017
Copy link

@ZHG2017 ZHG2017 commented Mar 7, 2024

Having put a bit more details on how to build from source either as a developer or as a user

@AntoinePrv AntoinePrv added the release::enhancements For enhancements PRs or implementing features label Mar 8, 2024
docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
docs/source/installation/micromamba-installation.rst Outdated Show resolved Hide resolved
docs/source/installation/micromamba-installation.rst Outdated Show resolved Hide resolved
docs/source/installation/micromamba-installation.rst Outdated Show resolved Hide resolved
docs/source/installation/micromamba-installation.rst Outdated Show resolved Hide resolved
docs/source/installation/micromamba-installation.rst Outdated Show resolved Hide resolved
@Hind-M Hind-M added release::ci_docs For PRs related to CI or documentation and removed release::enhancements For enhancements PRs or implementing features labels Mar 8, 2024
Copy link
Member

@AntoinePrv AntoinePrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, there are two sections that I don't think should be added for the sake of brevity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file should not be commited, we should add it to the .gitignore, sorry for that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see. I did not pay attention to this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that we ensure a clean up after running the tests rather than polluting the .gitignore file.

docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
docs/source/developer_zone/dev_environment.rst Outdated Show resolved Hide resolved
@AntoinePrv
Copy link
Member

@ZHG2017 could you rebase and remove the micromamba/tests/channel_a/linux-64/repodata.json file?

@AntoinePrv
Copy link
Member

It seems you have completely removed it. I meant remove any change so that there is no diff in this PR, sorry for the misunderstanding. You can achieve this with

git checkout main -- micromamba/tests/channel_a/linux-64/repodata.json
git add micromamba/tests/channel_a/linux-64/repodata.json
git commit -m "Reset repodata test file"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::ci_docs For PRs related to CI or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants