Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
DerThorsten committed Apr 25, 2024
1 parent b498f8e commit 6cf6223
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions quetz/tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -598,25 +598,28 @@ def test_start_server_local_without_deployment(
assert res.exit_code == 1
assert "The specified directory is not a deployment" in res.output


# these tests are strange and time out in the CI
# I thing the logic of the test might have been:
# * the test times out
# * this may fires SIGALRM since @pytest.mark.timeout(1) is used
# * this should trigger the installed signal handler
# * this should terminate the thread
# * we finally test if the process (which runs the server) was exited gracefully with a exitcode of 0
# * we finally test if the process (which runs the server)
# was exited gracefully with a exitcode of 0
# But long story short, these tests time out in the CI.
# Given their somewhat complicated logic / flow and how little they actually test I would say we just remove them.
# Given their somewhat complicated logic / flow and how little
# they actually test I would say we just remove them.
if False:

@pytest.mark.parametrize("sqlite_in_memory", [False])
@pytest.mark.timeout(1)
@pytest.mark.xfail(reason="time out")
def test_start_server_local_with_deployment_and_config_file(
empty_config_on_exit: None,
config,
config_dir,
create_channels_dir,
empty_config_on_exit: None,
config,
config_dir,
create_channels_dir,
create_tables,
):
"""Starting server with deployment directory"""
Expand All @@ -625,8 +628,6 @@ def test_start_server_local_with_deployment_and_config_file(
p.start()
p.join()
assert p.exitcode == 0
log.debug("finished")


@pytest.mark.parametrize("sqlite_in_memory", [False])
@pytest.mark.timeout(1)
Expand All @@ -649,7 +650,6 @@ def test_start_server_local_with_deployment_without_config_file(

assert p.exitcode == 0


@pytest.mark.parametrize("sqlite_in_memory", [False])
@pytest.mark.timeout(1)
@pytest.mark.xfail(reason="time out")
Expand Down

0 comments on commit 6cf6223

Please sign in to comment.