Skip to content

Commit

Permalink
Remove xattr as hard dependency (#602)
Browse files Browse the repository at this point in the history
* remove xattr and modify warning

* add repo variable

* change repo env variable

* fix env variable name

* maybe it is using the correct ref?

* remove commented out stuff

---------

Co-authored-by: Simon Bohnen <simonmbohnen@gmail.com>
  • Loading branch information
SimonBohnenQC and simonbohnen authored Feb 16, 2023
1 parent 58d5362 commit ff885bc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,5 +160,3 @@ jobs:
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
env:
RH_BRANCH: ${{ steps.branch-name.outputs.current_branch }}
2 changes: 2 additions & 0 deletions quetz/pkgstores.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import os.path as path
import shutil
import tempfile
import warnings
from contextlib import contextmanager
from os import PathLike
from threading import Lock
Expand All @@ -26,6 +27,7 @@
has_xattr = True
except ImportError:
has_xattr = False
warnings.warn("xattr not installed, not using it for file metadata")

from quetz.errors import ConfigError

Expand Down
1 change: 0 additions & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ install_requires =
typing_extensions
ujson
uvicorn
xattr
zstandard

[options.entry_points]
Expand Down

0 comments on commit ff885bc

Please sign in to comment.