Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sqlauth error parsing #569

Merged
merged 15 commits into from
Oct 31, 2022
Merged

Fix sqlauth error parsing #569

merged 15 commits into from
Oct 31, 2022

Conversation

simonbohnen
Copy link
Collaborator

No description provided.

@simonbohnen simonbohnen force-pushed the fix-sqlauth-error-parsing branch from ef7853e to 388dd87 Compare October 28, 2022 09:27
@simonbohnen simonbohnen added the bug Something isn't working label Oct 28, 2022
janjagusch
janjagusch reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work!

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Base: 82.57% // Head: 81.69% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (93f9c4c) compared to base (b660cf4).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   82.57%   81.69%   -0.88%     
==========================================
  Files          78       78              
  Lines        6059     6059              
==========================================
- Hits         5003     4950      -53     
- Misses       1056     1109      +53
Impacted Files Coverage Δ
quetz/pkgstores.py 42.45% <0.00%> (-11.60%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

janjagusch
janjagusch reviewed Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

plugins/quetz_sql_authenticator/quetz_sql_authenticator/api.py Outdated Show resolved Hide resolved
janjagusch
janjagusch approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

@janjagusch janjagusch merged commit ae38be7 into mamba-org:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janjagusch janjagusch janjagusch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonbohnen @codecov-commenter @janjagusch @SimonBohnenQC