Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload endpoint #594

Merged
merged 9 commits into from
Feb 10, 2023
Merged

Fix upload endpoint #594

merged 9 commits into from
Feb 10, 2023

Conversation

simonbohnen
Copy link
Collaborator

@simonbohnen simonbohnen commented Feb 9, 2023

Modify the upload endpoint to include

  • updating the channeldata
  • reindexing the channels

Also replace the incorrect NoReturn type hints with None. Functions which return without a value should be typed as None, NoReturn is meant for functions which never finish.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Base: 82.52% // Head: 81.65% // Decreases project coverage by -0.87% ⚠️

Coverage data is based on head (cfd07f8) compared to base (2a92258).
Patch coverage: 72.72% of modified lines in pull request are covered.

❗ Current head cfd07f8 differs from pull request most recent head 63abbf1. Consider uploading reports for the commit 63abbf1 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   82.52%   81.65%   -0.87%     
==========================================
  Files          78       78              
  Lines        6059     6062       +3     
==========================================
- Hits         5000     4950      -50     
- Misses       1059     1112      +53     
Impacted Files Coverage Δ
quetz/main.py 86.50% <0.00%> (-0.37%) ⬇️
quetz/cli.py 75.08% <100.00%> (ø)
quetz/config.py 90.15% <100.00%> (ø)
quetz/pkgstores.py 42.45% <100.00%> (-11.60%) ⬇️
quetz/tasks/mirror.py 90.49% <0.00%> (+1.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@simonbohnen simonbohnen added the bug Something isn't working label Feb 9, 2023
@simonbohnen simonbohnen marked this pull request as ready for review February 9, 2023 21:29
@wolfv
Copy link
Member

wolfv commented Feb 10, 2023

perfect, I think now we can also update mypy! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants