-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix upload endpoint #594
Fix upload endpoint #594
Conversation
Codecov ReportBase: 82.52% // Head: 81.65% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
==========================================
- Coverage 82.52% 81.65% -0.87%
==========================================
Files 78 78
Lines 6059 6062 +3
==========================================
- Hits 5000 4950 -50
- Misses 1059 1112 +53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
perfect, I think now we can also update |
Modify the
upload
endpoint to includechanneldata
Also replace the incorrect
NoReturn
type hints withNone
. Functions which return without a value should be typed asNone
,NoReturn
is meant for functions which never finish.