Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quetz compatible with SQLAlchemy 2.0 #598

Merged
merged 13 commits into from
Feb 15, 2023

Conversation

simonbohnen
Copy link
Collaborator

@simonbohnen simonbohnen commented Feb 10, 2023

Closes #587.

@simonbohnen simonbohnen changed the title Make quetz compatible with SQLAlchemy 2.0.0 Make quetz compatible with SQLAlchemy 2.0 Feb 10, 2023
@simonbohnen simonbohnen added the bug Something isn't working label Feb 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 82.53% // Head: 81.57% // Decreases project coverage by -0.96% ⚠️

Coverage data is based on head (56ff8d5) compared to base (e76b001).
Patch coverage: 87.50% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   82.53%   81.57%   -0.96%     
==========================================
  Files          78       78              
  Lines        6062     6068       +6     
==========================================
- Hits         5003     4950      -53     
- Misses       1059     1118      +59     
Impacted Files Coverage Δ
quetz/db_models.py 95.78% <75.00%> (-1.12%) ⬇️
quetz/dao.py 89.16% <100.00%> (ø)
quetz/migrations/env.py 69.44% <100.00%> (ø)
quetz/pkgstores.py 42.45% <0.00%> (-11.60%) ⬇️
quetz/tasks/mirror.py 89.43% <0.00%> (-1.06%) ⬇️
quetz/main.py 86.38% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wolfv
Copy link
Member

wolfv commented Feb 10, 2023

wow. nice!

@simonbohnen simonbohnen marked this pull request as ready for review February 10, 2023 14:15
@simonbohnen simonbohnen requested a review from wolfv February 10, 2023 14:21
@janjagusch
Copy link
Collaborator

@simonbohnen, should we go ahead and merge this?

@simonbohnen
Copy link
Collaborator Author

@simonbohnen, should we go ahead and merge this?

Yes please! 😁

@janjagusch janjagusch merged commit fb57621 into mamba-org:main Feb 15, 2023
@janjagusch janjagusch added maintenance and removed bug Something isn't working labels Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quetz is incompatible with sqlalchemy>=2.0.0
4 participants