Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osx-arm64 version for testing on newer apple devices #631

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

YYYasin19
Copy link
Collaborator

Hey,
while checking out the development instructions for setting up a new server I realized that this command

mamba install --strict-channel-priority -c http://localhost:8000/get/channel0 -c conda-forge xtensor

does not work on Apple Silicon devices, since no xtensor is being downloaded.
I added an osx-arm64 version and updated the versions somewhat.

Thanks!

@AndreasAlbertQC
Copy link
Collaborator

@YYYasin19 Thanks for the PR. Could you please update the README accordingly with the updated file names?

@AndreasAlbertQC
Copy link
Collaborator

The lint ci failure is now fixed on main, please rebase

@YYYasin19 YYYasin19 force-pushed the update-download-script branch from e7e93f6 to 0d9d1c2 Compare May 31, 2023 19:49
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.87 ⚠️

Comparison is base (fbd9ae2) 82.19% compared to head (0d9d1c2) 81.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   82.19%   81.33%   -0.87%     
==========================================
  Files          78       78              
  Lines        6140     6140              
==========================================
- Hits         5047     4994      -53     
- Misses       1093     1146      +53     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@janjagusch janjagusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janjagusch janjagusch merged commit b1ac607 into mamba-org:main Jun 1, 2023
@janjagusch janjagusch changed the title add: osx-arm64 version for testing on newer apple devices Add osx-arm64 version for testing on newer apple devices Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants