Make sqlalchemy pool settings configurable #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanJaguschQC
approved these changes
May 31, 2023
janjagusch
approved these changes
May 31, 2023
Co-authored-by: Jan Jagusch <77677602+JanJaguschQC@users.noreply.github.com>
AndreasAlbertQC
force-pushed
the
2023-05-31_configurable-pool-size
branch
from
f3b8007 to
96ff989
Compare
janjagusch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration settings for the sqlalchemy pool size and overflow settings.
Additionally, the docs for the sqlalchemy configuration section are extended. While doing that, I realized that there is a setting
database_plugin_path, which afaict is unused. I have not removed it for now, but if anyone knows what it's about, let me know.