Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set user roles when role is None #669

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

janjagusch
Copy link
Collaborator

@janjagusch janjagusch commented Sep 28, 2023

The user role None, indicating that the user has no permissions on the server, was accidentally removed from the data model in #656. This PR brings it back.

@janjagusch janjagusch added the bug Something isn't working label Sep 28, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5a43902) 83.64% compared to head (241fe02) 83.59%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   83.64%   83.59%   -0.05%     
==========================================
  Files          79       79              
  Lines        6230     6230              
==========================================
- Hits         5211     5208       -3     
- Misses       1019     1022       +3     
Files Coverage Δ
quetz/main.py 89.89% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janjagusch janjagusch marked this pull request as ready for review September 28, 2023 15:36
@janjagusch janjagusch merged commit 3cbd27a into mamba-org:main Sep 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants