Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin typer to address issues in argument defaults #672

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Pin typer to address issues in argument defaults #672

merged 2 commits into from
Nov 22, 2023

Conversation

RobinHolzingerQC-OLD
Copy link
Contributor

@RobinHolzingerQC-OLD RobinHolzingerQC-OLD commented Nov 22, 2023 •
edited by ivergara
Loading

Motivation

The typer API has changed at some point. v0.7.0 won't work anymore but it's the version installed on a fresh development environment.

See:

  File "<...>/quetz/cli.py", line 330, in <module>
    path: Annotated[str, typer.Argument(help="The path of the deployment")],
TypeError: Argument() missing 1 required positional argument: 'default'

@RobinHolzingerQC-OLD RobinHolzingerQC-OLD marked this pull request as draft November 22, 2023 09:54
@RobinHolzingerQC-OLD RobinHolzingerQC-OLD changed the title build: Pin typer and add defaults according to api change build: Pin typer to address issues in argument defaults Nov 22, 2023
@RobinHolzingerQC-OLD RobinHolzingerQC-OLD marked this pull request as ready for review November 22, 2023 11:03
@ivergara ivergara added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 22, 2023
ivergara
ivergara approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@ivergara ivergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I just did stumble over this issue last night.

@janjagusch janjagusch removed the bug Something isn't working label Nov 22, 2023
@janjagusch janjagusch changed the title build: Pin typer to address issues in argument defaults Pin typer to address issues in argument defaults Nov 22, 2023
@janjagusch janjagusch added maintenance bug Something isn't working and removed dependencies Pull requests that update a dependency file maintenance labels Nov 22, 2023
@janjagusch janjagusch merged commit 0b49467 into mamba-org:main Nov 22, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janjagusch janjagusch janjagusch approved these changes

@ivergara ivergara ivergara approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobinHolzingerQC-OLD @ivergara @janjagusch @robinholzi