Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include '.conda' packages for reindexing from package store #705

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

najose
Copy link

@najose najose commented Sep 3, 2024

Currently only .tar.bz2 packages are considered for reindexing. This PR will allow reindexing to see .conda packages too.

fixes #703

@wolfv wolfv added the bug Something isn't working label Sep 3, 2024
@najose
Copy link
Author

najose commented Sep 4, 2024

@wolfv, thanks for the commit to fix the CI, seems like some of the workflows are still failing.

@kuepe-sl
Copy link
Contributor

kuepe-sl commented Dec 5, 2024

I recently started trying out the new .conda packages and they work mostly well - except that they don't appear as "current version" in the Quetz API.

I tracked the bug down to the missing reindexing, which causes multiple packages to have version_order = 0 in the database.

It would be really awesome if you could merge this, so that the issue is solved, because currently the API is pretty broken as soon as .conda packages are involved.

@najose
Copy link
Author

najose commented Dec 9, 2024

@wolfv, Can we merge this change? Are the CI errors related to the change in the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reindexing .conda packages
3 participants