-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add more tracing #55
Conversation
941ee7c
to
2107341
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
2107341
to
ae6c794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
You changed a lot of places to display ids instead of the rhings the ids represent. I can understand that this makes debugging some things easier but it also makes following the general flow of the algorithm much harder. Could we maybe show both? The id and the representation of the id?
You inplemented Display in a few places in a way that almost exactly mimics the (derived) Debug trait. Maybe you can use rhat instead?
I think the levels are sometimes quite high. Perhaps consider downgrading some info and debug logs to trace level instead?
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
c81827e
to
fdc4765
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
4c692ee
to
a37a65a
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
No description provided.