chore: add diagnostics and segmented vector #85
+262
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool stuff! Did you benchmark that using The diagnostics are very nice. |
|
I have not, I will run a benchmark at the end of the day. |
|
But without it, I ran into issue with the solver trying to allocate 1.5GB in one go, which causes an OOM. |
|
These are the timings results:
There is no significant increase in outliers, but on average, the code became slightly slower.
Ill try removing the segvec later and try again to see if thats the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of
segvec::SegVecto allocate clauses. This reduces the number of very large allocations performed by the library.I also added functionality to report diagnostics to make it easier to debug what is going on.