Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust macOS CI to use three simultaneous jobs #13056

Closed
wants to merge 1 commit into from

Conversation

belegdol
Copy link
Contributor

@belegdol belegdol commented Dec 8, 2024

As of December 2024, all the used gitlab hosted runners have 7 GB of RAM and 14 GB of storage. macOS runner has 3 CPUs whereas Linux and Windows runners have 2. Since Windows and Linux jobs already use 3 jobs, it should also work for macOS.

As of December 2024, all the used gitlab hosted runners have 7 GB of RAM
and 14 GB of storage. macOS runner has 3 CPUs whereas Linux and Windows
runners have 2. Since Windows and Linux jobs already use 3 jobs, it
should also work for macOS.
@belegdol
Copy link
Contributor Author

belegdol commented Dec 8, 2024

macOS job only got two minutes faster which could just as well be the normal variance. Looks like this might not be worth it.

@cuavas
Copy link
Member

cuavas commented Dec 8, 2024

I don’t want to do this, because on a Linux VM with 6GB of RAM and lots of things stopped to free up memory (e.g. graphical session manager stopped), a full build hits swap at a couple of points even with -j4 due to the way it ends up trying to build the memory system templates in libemu and the Lua bindings templates in libfrontend at the same time, and the M68000 CPU core files. I want to stick with -j2 on these 7GB VMs to ensure there’s some headroom. I’ve explained this every time someone opens a PR to do this.

@cuavas cuavas closed this Dec 8, 2024
@belegdol belegdol deleted the macos_ci_three_threads branch December 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants