Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/vasil.pashov/index file refactor #1472

Merged

Conversation

vasil-pashov
Copy link
Collaborator

Refactor index.hpp

Move the functions in a .cpp file. Add explicit template instantiations for the CRTP base class in the cpp file.

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

Vasil Pashov and others added 28 commits February 27, 2024 18:21
…n. Arctic no longer persists the dtype because empty columns are set to be of empty type. Which in Python terms is object dtype.
… tests for the compat-36 and compat-38 versions. The behavior shall be fixed with a later commit
Modify the normalization so that 0-rowed dataframe uniformly return
Index([]) with dtype='object'
@vasil-pashov vasil-pashov merged commit e6c4f28 into feature/empty_index Apr 2, 2024
113 of 114 checks passed
@vasil-pashov vasil-pashov deleted the dev/vasil.pashov/index_file_refactor branch April 2, 2024 14:29
vasil-pashov added a commit that referenced this pull request Apr 24, 2024
Refactor index.hpp

Move the functions in a .cpp file. Add explicit template instantiations
for the CRTP base class in the cpp file.

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

---------

Co-authored-by: Vasil Pashov <vasil.pashov@man.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants