Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag empty_index #1475

Merged
merged 9 commits into from
Apr 23, 2024

Conversation

vasil-pashov
Copy link
Collaborator

@vasil-pashov vasil-pashov commented Apr 5, 2024

Reference Issues/PRs

Relates to: #1429, #1440

What does this implement or fix?

Feature flag the use of empty type. It uses the same library config option as the empty column type. In order to preserve behavior empty dataframes will use DataTimeIndex.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@vasil-pashov vasil-pashov force-pushed the feature/feature_flag_empty_index branch from 55c0716 to 3f5f783 Compare April 5, 2024 16:18
@vasil-pashov vasil-pashov marked this pull request as ready for review April 5, 2024 16:25
@vasil-pashov vasil-pashov marked this pull request as draft April 9, 2024 08:58
@vasil-pashov vasil-pashov force-pushed the feature/feature_flag_empty_index branch from 3f5f783 to 2effe0c Compare April 10, 2024 07:13
@vasil-pashov vasil-pashov force-pushed the feature/feature_flag_empty_index branch from 38adaf6 to 0e1f11c Compare April 16, 2024 08:13
@vasil-pashov vasil-pashov marked this pull request as ready for review April 16, 2024 10:59
python/arcticdb/version_store/_store.py Outdated Show resolved Hide resolved
cpp/arcticdb/version/schema_checks.hpp Outdated Show resolved Hide resolved
cpp/arcticdb/version/schema_checks.hpp Outdated Show resolved Hide resolved
@vasil-pashov vasil-pashov merged commit b4b6cbe into feature/empty_index Apr 23, 2024
114 checks passed
@vasil-pashov vasil-pashov deleted the feature/feature_flag_empty_index branch April 23, 2024 16:23
vasil-pashov added a commit that referenced this pull request Apr 24, 2024
#### Reference Issues/PRs
Relates to: #1429, #1440

#### What does this implement or fix?
Feature flag the use of empty type. It uses the same library config
option as the empty column type. In order to preserve behavior empty
dataframes will use DataTimeIndex.
#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->

---------

Co-authored-by: Vasil Pashov <vasil.pashov@man.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants