Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed clonable concept #229

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fixed clonable concept #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 19 additions & 29 deletions include/sparrow/utils/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

namespace sparrow
{

/**
* @brief A value_ptr is a smart pointer that behaves like a value.
* It manages the lifetime of an object of type T which is not stored in the `value_ptr` but a pointer,
Expand Down Expand Up @@ -134,26 +133,17 @@ namespace sparrow

std::unique_ptr<T> value_;
};

// TODO, refactor in a seperate PR as this concept is not working.
// ArrayBase* is **NOT** convertible to Derived*.

// /**
// * Matches types that provide a `clone` method.
// *
// * This concept checks if a type provides a `clone` method that
// * returns a pointer convertible to a pointer to the type.
// *
// * @tparam T The type to check
// */
// template <class T>
// concept clonable = requires(const T* t)
// {
// { t->clone() } -> std::convertible_to<T*>
// };


/**
* Matches types that provide a `clone` method.
*
* This concept checks if a type T provides a `clone` method that
* returns a pointer to an object whose type is a base of T.
*
* @tparam T The type to check
*/
template <class T>
concept clonable = true;
concept clonable = std::derived_from<T, std::decay_t<decltype(*std::declval<T*>()->clone())>>;

/**
* Smart pointer behaving like a copiable std::unique_ptr.
Expand Down Expand Up @@ -234,15 +224,6 @@ namespace sparrow
internal_pointer m_data;
};




template <class T, class... Args>
cloning_ptr<T> make_cloning_ptr(Args&&... args)
{
return cloning_ptr<T>(new T(std::forward<Args>(args)...));
}

template <class T>
void swap(cloning_ptr<T>& lhs, cloning_ptr<T>& rhs) noexcept;

Expand Down Expand Up @@ -273,6 +254,9 @@ namespace sparrow
std::compare_three_way_result_t<typename cloning_ptr<T>::pointer>
operator<=>(const cloning_ptr<T>& lhs, std::nullptr_t) noexcept;

template <class T, class... Args>
cloning_ptr<T> make_cloning_ptr(Args&&... args);

/******************************
* cloning_ptr implementation *
******************************/
Expand Down Expand Up @@ -448,4 +432,10 @@ namespace sparrow
using pointer = typename cloning_ptr<T>::pointer;
return lhs.get() <=> static_cast<pointer>(nullptr);
}

template <class T, class... Args>
cloning_ptr<T> make_cloning_ptr(Args&&... args)
{
return cloning_ptr<T>(new T(std::forward<Args>(args)...));
}
}
Loading