Fixed copy semantic of arrays #244
Merged
+818
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerThorsten
approved these changes
Oct 22, 2024
Alex-PLACET
reviewed
Oct 22, 2024
| list_arr3 = list_arr; | ||
| CHECK_EQ(list_arr3, list_arr); | ||
| } | ||
|
|
There was a problem hiding this comment.
There is no "move" test for this one ?
There was a problem hiding this comment.
Not yet, because that would require implementing the move semantic in all the arrays, while I think that with my incoming "refactoring" of the arrow_proxy class, we can actually get it for free. I'll add them in the same PR.
test/test_list_array.cpp
Outdated
| @@ -266,7 +331,7 @@ namespace sparrow | |||
| } | |||
| } | |||
| } | |||
| delete schema.format; | |||
| //delete schema.format; | |||
Alex-PLACET
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.