Allow Ethereum host to be configured by URL #13
Conversation
…thereumex. This patch passes through an HTTP options config from the caller. This allows us to set the configuration (such as connect and recv timeout) from the caller into EthereumEx. As there are a large number of possible configuration options, it seems easier to pass the options from HTTPoison to the caller than to expose them through our own interface.
config/dev.exs
Outdated
| @@ -1,5 +1,6 @@ | |||
| use Mix.Config | |||
| config :ethereumex, | |||
| url: System.get_env("ETHEREUM_URL"), | |||
There was a problem hiding this comment.
@hayesgm Instead of adding another url option we can add url_path option so the Ethereum host will be configured:
"#{scheme()}://#{host()}#{port()}/#{url_path()}"
the only thing that should be changed is Config.port method
@spec port() :: integer()
defp port do
port = env_var(:port)
if is_nil(port), do: "", else: port
end
@spec env_var(atom()) :: binary() | integer()| nil
defp env_var!(var) do
Application.fetch_env!(:ethereumex, var)
end
end
What do you think?
There was a problem hiding this comment.
or we can remove scheme, host, port options and just use url option
There was a problem hiding this comment.
Yeah, I personally prefer a URL option, since it's easier to pass in and it's easier to construct a URL from scheme, host and port instead of the reverse. This ends up being important because Infura gives you a full URL to access their nodes.
There was a problem hiding this comment.
Let me know if you want me to move forward with changing to a URL-only config.
There was a problem hiding this comment.
@hayesgm it's ok, let's use a URL-only config
| @@ -17,7 +17,7 @@ defmodule Ethereumex.HttpClient do | |||
|
|
|||
| @spec post_request(binary()) :: {:ok | :error, any()} | |||
| defp post_request(payload) do | |||
| response = rpc_url() |> HTTPoison.post(payload, [{"Content-Type", "application/json"}]) | |||
| response = rpc_url() |> HTTPoison.post(payload, [{"Content-Type", "application/json"}], Ethereumex.Config.http_options()) | |||
There was a problem hiding this comment.
I think this is a good idea. We should implement this to generic Client requests as well, useful for things like timeout threshold of HTTPoision. What do you think @ayrat555 ?
There was a problem hiding this comment.
Yes, it's nice feature. I am just waiting for @hayesgm to move to URL option in config. And it's good to merge.
|
Upgraded this to exclusively use the |
This patch adds the ability to configure the Ethereum host via a URL, e.g.
Additionally, we allow http options to be passed in to the RPC calls (e.g. to configure timeouts).