Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash if response body doesn't contain valid JSON. #19

Merged

Conversation

the-kenny
Copy link
Contributor

Uses Poison.decode instead of its throwing variant Poison.decode! and uses the with macro for graceful error handling.

Fixes #18

@the-kenny
Copy link
Contributor Author

Note that I tried to add a few tests for the new error behavior, but got stuck as I couldn't easily spawn a mocked Ethereumex.HttpClient

@ayrat555
Copy link
Member

ayrat555 commented Feb 9, 2018

@the-kenny can you bump version and add your changes to CHANGELOG?

@ayrat555 ayrat555 merged commit daa4e84 into mana-ethereum:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants