removing tunneling requests #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to add these changes to |
ayrat555
approved these changes
Oct 24, 2018
InoMurko
force-pushed
the
optimize_client_behaviour
branch
from
895c9e2
to
796092a
Compare
masonforest
approved these changes
Oct 25, 2018
masonforest
reviewed
Oct 25, 2018
| Map.put(req_data, "id", index + id) | ||
| end) | ||
|
|
||
| _ = Counter.increment(:rpc_counter, id + Enum.count(params)) |
There was a problem hiding this comment.
Just curious: why do we update the counter by the number of params?
I would have expected we always incremented it by 1.
There was a problem hiding this comment.
I was also wondering what the idea is (but didn’t want to address it as it’s not part of the PR). I think this is preparing the requests for the batch call - so the number of calls in a batch?
There was a problem hiding this comment.
Got it. Yeah, agreed this is outside the scope of this PR. I made an issue so we can look into it. 🙂
masonforest
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the GenServer that was the originating process performing the HTTP requests.
Added a ETS table/module that tracks the RPC counter and exposed the needed functionality.
The underlying http client - hackney - now maintains a pool of connections named default.
https://github.com/edgurgel/httpoison#connection-pools
Other issue:
IpcServer is still funnelled. If there's demand we could define a worker number and open a pool of IPC connections that IpcClient would use and rotate between them.