feature: provide configuration for locked id response value #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrat555
requested changes
Oct 20, 2019
InoMurko
force-pushed
the
exvcr_recording_helpers
branch
from
35ff360
to
7feeaba
Compare
ayrat555
approved these changes
Oct 21, 2019
|
Thanks @ayrat555! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We're using ethereumex at OmiseGO and we're recording Eth client responses with ExVCR but because of the stateful protocol property (incrementing ID's) we're hacking it around with reseting counters in ETS. But I guess it could be done cleaner by locking yourself on a specific value... here's a PR that does that.