Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unremovable default hackney pool #82

Merged
merged 2 commits into from
Dec 27, 2020

Conversation

izelnakri
Copy link
Collaborator

@izelnakri izelnakri commented Dec 8, 2020

This was needed, because my tests were failing due to this new default hackney pool usage that was not removable from outside. #81

NOTE: we should cut a MINOR release afterwards as this is a breaking change.

@izelnakri izelnakri changed the title Remove unremovalable default hackney pool Remove unremovable default hackney pool Dec 8, 2020
@ayrat555
Copy link
Member

@izelnakri Can you please give some instructions for reproducing your error?

@izelnakri
Copy link
Collaborator Author

izelnakri commented Dec 14, 2020

@ayrat555 sure, the link I provided above explains it: #81

The code diff between those links is the reason why I had to disable a pool for my use case. When my eth library test case starts it makes thousands of http requests that go to a pool and they get stuck, even when the testrpc server goes live, making the tests unable to run/hang since they wait for a successful rpc response.

Also I had to do thousands of requests, couldnt figure out a better way to test eth library since it depends on an external testrpc node.js cli/process, and couldnt figure it out if elixir Ports could be usable after hours/days of investigation back then.

@InoMurko
Copy link
Member

@izelnakri the checkout_timeout comes from your pool being exhausted. which comes from a hackney bug I reported months ago:
benoitc/hackney#643

Are you sure this two things are not releated?

@izelnakri
Copy link
Collaborator Author

@izelnakri the checkout_timeout comes from your pool being exhausted. which comes from a hackney bug I reported months ago:
benoitc/hackney#643

Are you sure this two things are not releated?

👍 most likely they are related, checking it now. Also we should provide this option to adjust the pool, make the library as flexible as possible so I think this MR should be merged regardless 😉

@InoMurko
Copy link
Member

Absolutely.

Please force hackney from the tip of master and try out your test.

@izelnakri
Copy link
Collaborator Author

@InoMurko yes It worked. Lets merge this PR and then update httpoison to 1.7.0, not sure if this would fix the hackney issue but we'll see I guess ;)

@ayrat555 ayrat555 merged commit 7e53d63 into mana-ethereum:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants