Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple distillery build #398

Closed
wants to merge 1 commit into from
Closed

Conversation

masonforest
Copy link
Contributor

Distillery will allow us to
build mana binaries which can be run by users.

This is the default configuration generated by release.init new
releases can be generated by running mix release.

Other changes:

  • Enable sync by default in dev environment
  • Use an application configuration value for db_path instead of relying on Mix.env() as Mix.env() isn't available in releases.
  • Add debug logging to see when each Supervisor comes online

[Distillery](https://github.com/bitwalker/distillery) will allow us to
build mana binaries which can be run by users.

This is the default configuration generated by `release.init` new
releases can be generated by running `mix release`.

Other changes:

* Enable sync by default in dev environment
* Use an application configuration value for `db_path` instead of relying on `Mix.env()` as `Mix.env()` isn't available in releases.
* Add debug logging to see when each Supervisor comes online
@ghost ghost assigned masonforest Aug 30, 2018
@ghost ghost added the status: in progress label Aug 30, 2018
@@ -0,0 +1,3 @@
*.*
!*.exs
!.gitignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor. But would you mind adding a newline at the end of this file? Mike Burns wrote a fantastic summary of why these get marked by GitHub https://robots.thoughtbot.com/no-newline-at-end-of-file

Copy link
Contributor

@MattMSumner MattMSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@masonforest
Copy link
Contributor Author

Closing for now. I'll reopen once we address: #409

@ghost ghost removed the status: in progress label Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants