Peer mngmt #639 #688
Merged
Peer mngmt #639 #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InoMurko
force-pushed
the
peer_mngmt2
branch
from
4bf0851
to
0f0b289
Compare
InoMurko
force-pushed
the
peer_mngmt2
branch
9 times, most recently
from
fa0dafc
to
d444f7c
Compare
InoMurko
requested review from
hayesgm,
ayrat555 and
willmeister
and removed request for
hayesgm
ayrat555
reviewed
Dec 3, 2018
ayrat555
reviewed
Dec 3, 2018
ayrat555
reviewed
Dec 3, 2018
willmeister
approved these changes
Dec 3, 2018
hayesgm
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to establish exact requirements of #639.
What this does at the moment is that it passes a observer module down the supervision tree to workers. The workers are inbound and outbound connections. These worker processes link themselves to the observer module, so that in case of disconnect, the observer can catch the exit and:
There's no logic yet when a connection gets dropped (either from ur or from them) - because I'm still figuring out what the logic should be. Like ... based on what should we pick a new peer?
The other part was that I removed the link between the PeerSupervisor and Kademlia. Kademlia now notifies the observer module of rounds and the flow of attaching dynamic children to outbound connections tree.