Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bytes.hex/bytes.fromhex instead of binascii #2119

Closed
williballenthin opened this issue Jun 4, 2024 · 0 comments
Closed

use bytes.hex/bytes.fromhex instead of binascii #2119

williballenthin opened this issue Jun 4, 2024 · 0 comments
Assignees
@fariss
Labels
enhancement New feature or request good first issue Good for newcomers gsoc Work related to Google Summer of Code project.

Comments

@williballenthin
Copy link
Collaborator

Unrelated to this PR, I think we can replace

capa/capa/rules/__init__.py

Line 459 in 960ee86

b = codecs.decode(s.replace(" ", "").encode("ascii"), "hex")

with:

b = bytes.fromhex(s)

https://docs.python.org/3/library/stdtypes.html#bytes.fromhex

Originally posted by @s-ff in #2080 (review)
@williballenthin williballenthin added enhancement New feature or request good first issue Good for newcomers gsoc Work related to Google Summer of Code project. labels Jun 4, 2024
lakshayletsgo added a commit to lakshayletsgo/capa that referenced this issue Jul 28, 2024
@lakshayletsgo
mandiant#2119 issue: use bytes.fromhex instead of binascii
f93cc2b
@mr-tz mr-tz mentioned this issue Aug 1, 2024
Merged
3 tasks
mr-tz added a commit that referenced this issue Aug 9, 2024
@lakshayletsgo @mr-tz
#2119 issue: use bytes.fromhex instead of binascii (#2235)
87f6916 
* #2119 issue: use bytes.fromhex instead of binascii

---------

Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
@mr-tz mr-tz closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fariss fariss

Labels
enhancement New feature or request good first issue Good for newcomers gsoc Work related to Google Summer of Code project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@williballenthin @mr-tz @fariss