Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VMRayAnalysis model and call parser #2155

Merged
merged 15 commits into from
Jun 19, 2024
Merged

Add VMRayAnalysis model and call parser #2155

merged 15 commits into from
Jun 19, 2024

Conversation

r-sm2024
Copy link
Contributor

@r-sm2024 r-sm2024 commented Jun 18, 2024 •
edited
Loading

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@r-sm2024 r-sm2024 marked this pull request as ready for review June 18, 2024 21:35
mr-tz
mr-tz reviewed Jun 19, 2024
View reviewed changes
vmray_parser.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file?

mr-tz
mr-tz reviewed Jun 19, 2024
View reviewed changes
capa/features/extractors/vmray/models.py
# fncall: List[FunctionCall] = element(tag="fncall")


### models for summary_v2.json files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep all of these

@mr-tz
Copy link
Collaborator

mr-tz commented Jun 19, 2024

good progress, I've made some tweaks as well here

@mr-tz mr-tz merged commit 8757dad into mandiant:vmray-extractor Jun 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-sm2024 @mr-tz