binja: fix up analysis for the al-khaser_x64.exe_ file #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ad3f06.
williballenthin
approved these changes
Dec 4, 2024
tests/fixtures.py
Outdated
| @@ -180,6 +180,11 @@ def get_binja_extractor(path: Path): | |||
| if path.name.endswith("kernel32-64.dll_"): | |||
| settings.set_bool("pdb.loadGlobalSymbols", old_pdb) | |||
|
|
|||
| # Temporary fix for https://github.com/mandiant/capa/issues/2507. Remove this once it is fixed in binja | |||
There was a problem hiding this comment.
Suggested change
| # Temporary fix for https://github.com/mandiant/capa/issues/2507. Remove this once it is fixed in binja | |
| # TODO(xusheng6): Temporary fix for https://github.com/mandiant/capa/issues/2507. Remove this once it is fixed in binja |
There was a problem hiding this comment.
Updated accordingly!
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a better fix for #2507 by fixing up the binja analysis (i.e., manually defining the function at 0x14004b4f0)
This issue also exposes a bug when I previously introduced the optimization in b6763ac. It is not fixed in this PR as well
Checklist