Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mangadig] download issue #6886

Closed
Xeiv opened this issue Mar 17, 2024 · 6 comments · Fixed by #7020
Closed

[Mangadig] download issue #6886

Xeiv opened this issue Mar 17, 2024 · 6 comments · Fixed by #7020
Labels
Can't reproduce bug For those bugs devs can't reproduce

Comments

@Xeiv
Copy link

Xeiv commented Mar 17, 2024

Did you read the troubleshooting guide
Yes

Describe the bug
When I download chapters sometimes I get
mjs/engine/Connector.mjs:618 Error: Failed to load "https://mangadig.com/manga-rg308526/1/11.html" within the given timeout of 30 seconds! at mjs/engine/Request.mjs:323 EventTarget _getPageList @ mjs/engine/Connector.mjs:618
or
TypeError: Cannot read property 'isDevToolsOpened' of null at MangaDig.mjs:3 at MangaDig._getPages (MangaDig.mjs:3) at MangaDig._getPageList (Connector.mjs:615) at Chapter.mjs:111 EventTarget

To Reproduce
Steps to reproduce the behavior:

  1. Go to Mangadig
  2. Click on any series
  3. Download Multiple chapters
  4. first few downloads fine but then the errors start

Expected behavior
Chapters get downloaded

Screenshots
image

Context (please complete the following information):

  • OS: Windows 11
  • HakuNeko Version 6.1.7

Additional context
The chapters work fine when I open it in my browser or new window in hakuneko

@Xeiv Xeiv added the Bug Flaw, Failure or Fault leading to incorrect or unexpected Results label Mar 17, 2024
@MikeZeDev
Copy link
Contributor

MikeZeDev commented Mar 17, 2024

I tested a couple of them, it works. I am sorry, we cant test "any serie". The point of having a manga and a chapter is to reproduce the bug more easily, just dont say "any serie", mention one pls.

Also.... Did you really try nightly (like you should because you checked the box).

HakuNeko Version 6.1.7

Cause its not nightly.

Try nightly if it doesnt work give us a specific MANGA and CHAPTER. Were you binge downloading? Maybe you were blocked temporarily by the website?

@MikeZeDev MikeZeDev added Can't reproduce bug For those bugs devs can't reproduce and removed Bug Flaw, Failure or Fault leading to incorrect or unexpected Results labels Mar 17, 2024
@MikeZeDev
Copy link
Contributor

Maybe related as Mangadig and Coco are the same #6862

@Xeiv
Copy link
Author

Xeiv commented Mar 17, 2024

I tested a couple of them, it works. I am sorry, we cant test "any serie".

If you were bulk downloading i'd maybe the website blocked you, idk.

Also.... Did you really try nightly?

HakuNeko Version 6.1.7

Cause its not nightly.

Try nightly if it doesnt work give us a specific MANGA and CHAPTER. Were you binge downloading? Maybe you were blocked temporarily by the website?

Same issue with the nightly, the series is Divine Coffin Spirit,
I was binge downloading so might have gotten temp blocked but the exact chapter does work on the website and the new window in hakuneko when I check right after it fails
It randomly happens when I don't binge download too

Maybe related as Mangadig and Coco are the same #6862

Yeah I think so, this might help with the issue

Also I keep getting these warnings Provided mime type "image/webp" does not match the file signature and Connector.mjs:717 was replaced by "image/jpeg"! but I don't think it's related

@Sheepux Sheepux changed the title [Bug] Mangadig download issue [Mangadig] download issue Mar 17, 2024
@MikeZeDev
Copy link
Contributor

MikeZeDev commented Mar 17, 2024

Also I keep getting these warnings Provided mime type "image/webp" does not match the file signature and Connector.mjs:717 was replaced by "image/jpeg"! but I don't think it's related

It just means server tell wrong image type so we correct it. Its unrelated.
I mean the error you got is usually when there is something wrong while loading the page itself and hard to diagnose.

Maybe, try replacing the content of your Mangadig.mjs by this?
https://raw.githubusercontent.com/manga-download/hakuneko/cf8fb350f5e512d44bb86bb6252de0305405e28a/src/web/mjs/connectors/MangaDig.mjs

Because i use nightly but i may still have the file from the mentioned fix, so ofc it works for me 🤷

@Xeiv
Copy link
Author

Xeiv commented Mar 17, 2024

It just means server tell wrong image type so we correct it. Its unrelated. I mean the error you got is usually when there is something wrong while loading the page itself and hard to diagnose.

Ah okay

Maybe, try replacing the content of your Mangadig.mjs by this? https://raw.githubusercontent.com/manga-download/hakuneko/cf8fb350f5e512d44bb86bb6252de0305405e28a/src/web/mjs/connectors/MangaDig.mjs

Because i use nightly but i may still have the file from the mentioned fix, so ofc it works for me 🤷

I think this fixed it but not sure, I haven't gotten any errors after replacing it though. Thank you 😁

@MikeZeDev
Copy link
Contributor

MikeZeDev commented Mar 17, 2024

Please keep in mind next time haku update the file could be replaced by the old one. Fix is temporary so youll have do it again until it is officially available to the people.

MikeZeDev added a commit that referenced this issue Apr 24, 2024
Fixes #6886 ? 

relevant commit : manga-download/hakuneko-plugins@05bbb2e

Again, a one line commit for a nasty website :)

(Mangadig & Coco were tested)
MikeZeDev added a commit that referenced this issue Apr 24, 2024
Fixes #6886 ? 

relevant commit : manga-download/hakuneko-plugins@05bbb2e

Again, a one line commit for a nasty website :)

(Mangadig & Coco were tested)
serge-reboul pushed a commit to serge-reboul/hakuneko that referenced this issue Jun 30, 2024
ronny1982 pushed a commit that referenced this issue Jul 27, 2024
Fixes #6886 ? 

relevant commit : manga-download/hakuneko-plugins@05bbb2e

Again, a one line commit for a nasty website :)

(Mangadig & Coco were tested)
ronny1982 added a commit that referenced this issue Jul 28, 2024
* feat(Ascalon): create connector (#6661)

* Fid CovenScan domain (#6670)

Fixes #6463

* Fix ZeroScans: change url and fix paste support (#6671)

* Change url and fix paste support

* Use regex to extract slug

* FIx WestManga: change domain (#6669)

Fixes #6666

* Fix PojokManga : change domain (#6652)

Fixes #6650

* FIx XoxoComics: domain & manga listing (#6647)

Fixes #6646

* FIx MangaHub: change API & CDN domains (#6683)

Fixes #6682

Websites based on MH has been tested too :)

* FIX MangaEffect : no more wpmangaprotector (#6699)

Fixes #6698

* add mangasusuku (#6704)

* Lezhin : change manga list endpoint & language values (#6689)

* Lezhin : change manga list endpoint

* Lezhin : change locale code

* Fix InfernalVoidScans: use referer (#6705)

Fixes #6701

* RandomScan : rebranding to LuraToon (#6726)

* RandomScan : rebranding to LuraToon

* update randomscan icon

* Fix Ainzscans: domain and junk in manga title (#6714)

Fixes #6712

* feat(AGS): create connector (#6753)

* feat(Nyrax): create connector (#6754)

* Remove Assorted Scans (#6768)

* FIx AsuraScansTR : domain, Madara, no junk (#6713)

Fixes #6707

* FIx LikeManga: invalid css selector (#6745)

Turns out selector is invalid in our old chrome
Filtering picture another way

* Fix GekkouScans: change domain (#6740)

Fixes #6739

* Update MangasChan.mjs (#6752)

updating the link data

* Fix MangaGeko: change domain (#6757)

Fixes #6756

* Fix Nonbiri: rebranding & change domain (#6737)

Fixes #6736

* MangaHub.io: change CDN (#6771)

* FIx MangaTR: change manga list path (#6733)

Fixes #6731

* [mangadex] get list from CDN (#6774)

* get mangalist from cdn

* fix lint error

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Websites maintenance : AlliedFansub & Nivera (#6802)

* AlliedFansub: change domain and template Fixes #6793
* Nivera : change domain Fixes #6792

* Fix ComicK : change domain (#6779)

* FIx WebtoonHatti: change selector again (#6775)

* FIX TCBScans: workaround for 404 errors (#6376)

* FIX TCBScans: workarourd for 404 errors

1) Website changed url (unrelated)
2) They deliberately introduce missing junk pictures in popular manga chapters. 

Since they cant be distinguished by name pattern, we use another method ;)

* requested changes

* changed logic for fake pages

missing pages are always at the end, so we start testing pictures backwards and stop when its good.

* tbcscans: fire all promises and wait

* Fix Opiatoon: changte domain (#6809)

Fixes #6791

* ComicWalker: rebrand to KadoComi (#6808)

Fixes #6806

* Fix ManhuaPlus: domain and change template (#6825)

No more madara.

Fixes #6824

* FiX KomikAV: change domain & rebrnad to APKomik (#6839)

Closes #6837

* use more recent user-agent header (#6835)

* Fix TuMangaOnline: fix getting pages (#6684)

* FIx welovemanga.one: getting pages (#6715)

Fixes #6711

* Fix HentaiRead: get chapters and pages (#6777)

* Fix HentaiRead: get chapters and pages

* fix regex

* Fix lint

* try catch in promise

* Fix ManhwaFreak: change fomain and filters (#6851)

Fixes #6849

* Fix LyraScans: change domain & rebrand (#6857)

* Fix LyraScans: change domain & rebrand

Fixes #6856

* update icon

* Fix NeoxScan: change domain (#6860)

* FIx ResetScans : change domain (#6854)

Fixes #6853

* Fix SwatManga : change domain (#6844)

Fixes #6842

* Fix KomikNesia : change domain (#6873)

Fixes #6871

* Fix MangaToon: change CSS for chapters (#6887)

get rid of duplicate chapters

* Fix ComicK: update domain (#6897)

Fixes #6896

* Fix MangaSail : change domain (#6898)

Fixes #6894

* Fix MangaBat : change domain (#6899)

* Fix MangaStarz : change domain (#6901)

Fixes #6900

* change domain (#6910)

Co-authored-by: Abdullah-KS <78895454+Abdullah-KS@users.noreply.github.com>

* FIx Siyahmelek: change domain (#6915)

Fixes #6908

* Fix MangaTX : domain changed (#6916)

Fixes #6911

* Fix TopToon : update CSS selectors (#6906)

* Fix TopToon : update CSS selectors

Fixes #6905

* Update TopToon.mjs

* Update TopToon.mjs

* attempt to fix lint error

* dont use optional chaining

optional chaining doesnt work in stable build because electron version is too old

* Fix MagKan: use Comici Viewer (#6927)

Similar to YoungChampion, YoungAnimal, Comicride, ComicMedu, etc....

Fixes #6926

* Fix winterscan : change domain (#6935)

#6933

* fix MangaSect source (#6930)

* fix MangaSect source

* fix lint

* better mangasect fix

---------

Co-authored-by: Victor Abrate <me@vab.one>
Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Fix MoonWitchInLove : change domain (#6942)

Fixes #6936

* add connector monzeekomik (#6954)

* add connector monzeekomik

* fix lint

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Fix ComicExtra : change domain (#6951)

* FIx KomikAV: domain type (#6881)

Fixes #6879

* Fix Saikaiscan : change domain (#6963)

Fixes #6620

* Fix LxHentai: change domain (#6970)

Fixes #6968

* Lock ESLint Version (#6971)

* lock eslint version

* fix lint errors

* updated connector drakescans (#6995)

* updated connector drakescans

* change to correct class name

* Fix ZinManga: change domain (#6978)

* Change domain fo AnimePahe (#7002)

Fixes #7001

* Fix ShinigamiID: domain & break encryption (#7023)

custom WPmangaprotector, cute
Fixes #6667

* Fix Aniwave : fix "Filemoon" support (#7021)

* Fix Aniwave : fix "Filemoon" support

relevant commit manga-download/hakuneko-plugins@1a8f9e4

A single line change tbh

* filemoon: add delay

* Fix CocoManhua : getting pictures (#7020)

Fixes #6886 ? 

relevant commit : manga-download/hakuneko-plugins@05bbb2e

Again, a one line commit for a nasty website :)

(Mangadig & Coco were tested)

* add connector sakuranovel (#6964)

* add sakuranovel

* remove useless code

* fixed content errors

* Update SakuraNovel.mjs

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Fix RizzComics : change domain (#7039)

Fixes #7036

* FIx TopManhua: change domain and rebrand (#7040)

Fixes #6975

* Fix ManhwaFreak : change domain (#7042)

Late PM cause drunkyards in the street cant let me sleep.
Woooohooo.

* ComicWalker:  better manga list (#7003)

Fixes #7000

* Fix MangaCross: extends Comici & Rebrand (#7007)

* Fix MangaCross: extends Comici & Rebrand

Fixes #7006

* update icon

* Update LELScanVF.mjs (#7012)

* Fix Cycomi: getting chapter & getting volume pages (#7043)

* Fix FlameComics : handle "puzzles" (#7026)

Fixes #3972

* FIX UzayManga : website revamping (#7025)

* FIX UzayManga : website revamping 

Fixes #6503

* fix images path

* better promise

* Fixes Piccoma & PiccomaFR (#7024)

* Fixes #6430 (descrambling). Bonus : its simpler
* Fixes #6627
* Add manga list for PiccomaFR
* Fix clipboard 
* Better mangalist for Piccoma (but it takes way more time)

Fixes are inspired from Haruneko plugins for Piccoma, <3 ronny

* Fix Lezhin: get LZconfig from elsewhere (#7022)

also some code refactoring.

Fixes #6830

* Fix MangahubRU: various fixes (#7016)

*   Fix Mangalist CSS selector
 *   Get pages normally (no json)
 *   Fix Clipboard support
 *   Use referrer for pages
 *   Set adult cookie for chapters

* FIx WebtoonHatti: fix getting pages, again (#7015)

this time, with an added bonus.

* HeanCMS : handle new API (#7014)

* HeanCms handle new api

* TempleScan: change endpoint

* Fix ManhwaClub => Become ManhwaHentai (#7019)

* Fix ManhwaClub => Become ManhwaHentai

Fixes #6863
Fixes #6115

* Add files via upload

* Fix ComicKiba => Become Manhuagold (#7018)

* Fix ComicKiba => Become Manhuagold

Similar to manhuaplus
Fixes #6875

* Add files via upload

* Update ComicBoost.mjs (#7013)

* Fix SirenKomik: fix chapters list + get pictures without JS (#7017)

Fixes #6880

* Fix Mangapark : many stuff (#7034)

* Fix Mangapark : many stuff

* Fix NSFW cookie
* Fix Mangalist (V5)
* Fix chapters (V5)
* Use API to get pages list (V5)
* Default is now V5 with V3 fallbacks,

Fixes #7033

Discussion opened.

* fix var type

* Update MangaParkEN.mjs

* Update MangaParkEN.mjs

* LuminousScans : change domain (#7053)

* Fix NhatTruyen: change domain (#7051)

like every week.

Fixes #6949

* Lint fix WebtoonHatti.mjs (#7058)

* fix(DrakeScans): update domain (#7055)

* DemonSect : change domain (#7059)

Cloudflare, so its useless

* feat(CulturedWorks): create connector (#7057)

* feat(CulturedWorks): create connector

* refactor(CulturedWorks): remove "npm"

* add ReadAllComics and fix ComicExtra domain (#7074)

* add ReadAllComics fix ComicExtra domain

* fix linting issues

* add copy paste support

* Fix TruyenQQ: changfe domain (#7072)

* NightScans : change domain (#7082)

Closes #7081

* KnightNoFansub : change domain and add referer (#7085)

* Properly remove control codes chars from download path (#6721)

* Properly remove control codes chars from download path

Fixes #6718

* Update Storage.mjs

* WeLoMa.mjs : Change URL (#7088)

* Update WeLoMa.mjs

* Update WeLoMa.mjs

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* ManhuaScan => KaliScan (#7107)

basically, change domain

* Fix klm website change (#7105)

* fix KissAway.mjs

* fix with random extra character

* fix typo

* fix lint and stuff

* filter Olimposcan ads

---------

Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Fix TuMangaOnlineHentai: clipboard & pages (#7116)

Fixes #7115

* Piccoma : api change (#7117)

* Piccoma : api change

Fixes #7113

* Update Piccoma.mjs

* piccomafr : fix clipboard

* ImmortalUpdates: change domain (#7152)

Fixes #7145

* Fbsquads: change domain (#7174)

Fixes #7173

* FIx Ridibooks : getting pages (#7178)

Fixes #7177

* Fix tapas.io connection (#7180)

* updated tapas.io

* added clipboard support

* remove unused variable

* readability

* tapas : lint fix

---------

Co-authored-by: tkasriel <timothe.kasriel@gmail.com>
Co-authored-by: MikeZeDev <MikeZeDev@users.noreply.github.com>

* Use Node 20 for CI (#7182)

* Lock Puppeteer version

* use node 20 for CI

* revert packages.json changes

* MangaGeko: domain change & mangalist fix (#7140)

Fixes #7138

* Manhuagold : fix manga list, clipboard and chapters (#7186)

Fixes #7185

* ResetScans: change domain (#7192)

* Voidscans : Change domain (#7139)

* Voidscans : Change domain

Fixes #7135

* Update NtsVoidScans.mjs

remove space

* Delete src/web/mjs/connectors/NtsVoidScans.mjs

delete NtsVoidScans

* Delete src/web/img/connectors/ntsvoidscans

delete NtsVoidScans icon

* MangaFreak: change domain (#7197)

Fixes #7195

* Aniwave : fix checksums & getting playlist (#7196)

* Aniwave : fix checksums & getting playlist

* Fliemoon : fix getting playlist url

* Aniwave ; fix WAF antiscraper check

* try...catch in async promise

* ComiciViewer : fix manga list CSS (#7202)

Tested working with websites

ComicMedu
BigComics
ChampionCross
YoungChampion
MagKan

* MangaHasu: change domain (#7217)

Fixes #7216

* JiangzaiToon : change domain (#7218)

Fixes #6790

* NiveraFansub: update domain (#7232)

* Some websites maintenance (#7234)

* LuminousScans : change domain & filter pages

* Mindafansub : change domain & use Madara

* TonizuToon : change domain (#7233)

Fixes #7223

* MangaKita: change domain (#7237)

* MangaWT: change domain (#7243)

Fixes #7242

* feat(ShojoScans): create connector (#7244)

* Manhwax: change domain (#7254)

Fixes #7253

* some domain changes (#7246)

* KomikTap : change domainn

* KomikCast : change domain and fix getting pages & clipboard

* ManHuaGui: delay page script (#7265)

well, website is too slow

* ReadComicOnline.li: fix website (#7275)

* FIX : ReadComicOnline.li : updated script to get image URLs as the old JS variable is removed

Fixes 'lstImages is not defined' error and also catches the error instead of failing with a timeout

* implement suggestion by @ronny1982 , replacing blogspot size parameters with =s0

* Forgot to escape backslash with JS backtick quotes

* InfernalVoidScans: change domain (#7282)

Fixes #7279

* solve conflict with locked eslint version

* fix lint errors

* fix lint errors

---------

Co-authored-by: Tristan
Co-authored-by: MikeZeDev
Co-authored-by: trendbloat
Co-authored-by: akn19
Co-authored-by: ObserverOfTime
Co-authored-by: Luis Araújo
Co-authored-by: ZIRO
Co-authored-by: Abdullah-KS
Co-authored-by: Victor Abrate
Co-authored-by: Victor Abrate
Co-authored-by: Yevu David Efui
Co-authored-by: Sheep
Co-authored-by: yoanhg421
Co-authored-by: Torablue
Co-authored-by: realabertian
Co-authored-by: Asriel2137
Co-authored-by: tkasriel
Co-authored-by: Peter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can't reproduce bug For those bugs devs can't reproduce
Projects
None yet
2 participants