PHOTO broken since 0.9.7

[rfc2822]

I have updated the ez-vcard dependency in vcard4android from 0.9.6 to 0.9.7, which causes the generated PHOTO property to be broken, because there's an empty line after the end of the property (note the double [CR][LF] at the end):

BEGIN:VCARD[CR][LF]
VERSION:3.0[CR][LF]
UID:0bpdjwux-fy4i-y5pb-h6xd-k7rphj54jjen[CR][LF]
PRODID:+//IDN bitfire.at//DAVdroid/0.9vcard4android ez-vcard/0.9.7[CR][LF]
…
PHOTO;ENCODING=b;TYPE=jpeg:/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAAgGBgcGBQgHBwcJ[CR][LF]
CQgKDBQNDAsLDBkSEw8UHRofHh0aHBwgJC4nICIsIxwcKDcpLDAxNDQ0Hyc5PTgyPC4zNDL/2w[CR][LF]
 BDAQkJCQwLDBgNDRgyIRwhMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIy[CR][LF]
 MjIyMjIyMjIyMjL/wAARCALQAtADASIAAhEBAxEB/8QAHwAAAQUBAQEBAQEAAAAAAAAAAAECAw[CR][LF]
QFBgcICQoL/8QAtRAAAgEDAwIEAwUFBAQAAAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0Kx[CR][LF]
wRVS0fAkM2JyggkKFhcYGRolJicoKSo0NTY3ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3[CR][LF]
…
C7Mq9FJOB9B2p1shLkm3Z1PQqpNSarc29lcoIJJSW6llwPwrPeZoowYwUXrw5rn21Odx3R//2Q[CR][LF]
 ==[CR][LF]
[CR][LF]
REV:20151018T212428Z[CR][LF]
END:VCARD[CR][LF]

I'm quite sure that's because of some changes from 0.9.6 to 0.9.7 (because when setting the dependency back to 0.9.6, everything works again), but if you like, I can write a test.

[mangstadt]

Hey rfc2822,

By "broken" do you mean you tried to get Android to consume such a vCard, and it failed?

Yes, that empty line was added in 0.9.7. Someone reported an issue where Outlook 2010 sometimes has problems reading base64-encoded property values without a trailing empty line (see this issue). But if it's breaking on Android, then this issue should be revisited.

[rfc2822]

By "broken" do you mean you tried to get Android to consume such a vCard, and it failed?

No, I mean that DAVdroid (which is an Android app, which is the only relation between this issue and Android) generated the VCard (using ez-vcard), sent it to a CardDAV server (using HTTP PUT). This server then refused to accept the VCard because it couldn't parse it.

Yes, that empty line was added in 0.9.7. Someone reported an issue where Outlook 2010 sometimes has problems reading base64-encoded property values without a trailing empty line (see this issue). But if it's breaking on Android, then this issue should be revisited.

The issue is not related to Android at all. The issue is that other VCard parsers can't parse this VCard because it contains an (illegal? didn't scan the specs for that, but I have never seen empty lines in VCard before) empty line.

[mangstadt]

This server then refused to accept the VCard because it couldn't parse it.

Well, that's not good. Do you know what CardDAV server is being used?

The specs definitely don't say to include an empty line after base64 property values. Sounds like a case of Outlook being "special".

[rfc2822]

I believe it was the Oracle Communications Contacts server. However, I'd expect other servers to reject such VCards, too.

Would it be possible to enable (Outlook-)workarounds only on request?

[mangstadt]

That's what I'm thinking. Some sort of reader.setOutlookCompatibility(true).

[mangstadt]

Added VCardWriter.setOutlookCompatibility() method. Outlook compatibility is disabled by default.

Fixed in c8da9a4