Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FoldedLineWriter: fix folding inside surrogate pairs #36

Merged
merged 2 commits into from
Dec 5, 2015
Merged

FoldedLineWriter: fix folding inside surrogate pairs #36

merged 2 commits into from
Dec 5, 2015

Conversation

blendmaster
Copy link
Contributor

Tricky bug, since it only happens if you happen to have a surrogate pair right at the line boundary.

@codecov-io
Copy link

Current coverage is 76.13%

Merging #36 into master will not affect coverage as of efa2224

@@            master     #36   diff @@
======================================
  Files          203     203       
  Stmts         7374    7378     +4
  Branches      1141    1143     +2
  Methods                          
======================================
+ Hit           5614    5617     +3
- Partial        237     238     +1
  Missed        1523    1523

Review entire Coverage Diff as of efa2224

Powered by Codecov. Updated on successful CI builds.

@mangstadt mangstadt added the bug label Dec 5, 2015
mangstadt added a commit that referenced this pull request Dec 5, 2015
@mangstadt
Merge pull request #36 from fullcontact/surrogate-pair-folding-upstream
f238de6 
FoldedLineWriter: fix folding inside surrogate pairs
@mangstadt mangstadt merged commit f238de6 into mangstadt:master Dec 5, 2015
@mangstadt
Copy link
Owner

Thank you, @blendmaster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blendmaster @codecov-io @mangstadt