Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TelUri parsing performance #38

Closed
wants to merge 2 commits into from
Closed

Improve TelUri parsing performance #38

wants to merge 2 commits into from

Conversation

blendmaster
Copy link
Contributor

More upstream parity from fullcontact/ez-vcard.

@blendmaster
TelUri: replace terrible regex with manual parse
10b7a59 
That regex is sloow.
@blendmaster
TelUri: don't throw IAE for bad parses
a4bd5da 
instead return null, for less expense when parsing
lots of vcards.
@codecov-io
Copy link

Current coverage is 76.10%

Merging #38 into master will decrease coverage by -0.03% as of a802efc

@@            master    #38   diff @@
=====================================
  Files          203    203       
  Stmts         7374   7374       
  Branches      1141   1144     +3
  Methods                         
=====================================
- Hit           5614   5612     -2
- Partial        237    239     +2
  Missed        1523   1523

Review entire Coverage Diff as of a802efc

Powered by Codecov. Updated on successful CI builds.

@mangstadt
Copy link
Owner

Thanks for the idea, @blendmaster. I went a step further and removed calls to String.split(), since this method uses a regular expression as well. See commits 0e232d5 and 389ef2b.

@mangstadt mangstadt closed this Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blendmaster @codecov-io @mangstadt