Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resizing of configurable features #878

Merged
merged 6 commits into from
Jan 27, 2020

Conversation

davejsdev
Copy link

Reason for change

Testing

  • Create a configured plan in storybook
  • go to resize plan selector and verify that all values are the same as when the resource was created.
  • change the configured values and click the resize button
  • check in resource details that the values have been updated on the resource

Checklist

  • CHANGELOG: The Unreleased section of CHANGELOG was updated
  • Prop changes: docs were updated
  • Prop changes: E2E tests were updated, testing from the highest level possible
  • Platform testing: If this change should be tested against a platform, has it been?

@davejsdev davejsdev requested review from sslotsky, drwpow, domenicrosati and a team January 27, 2020 02:18
@vercel
Copy link

vercel bot commented Jan 27, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/manifold/ui/mls90pkf1
✅ Preview: https://ui-git-davejs-resize-resource-features.manifold.now.sh

@drwpow drwpow temporarily deployed to manifold-ui-stage-pr-878 January 27, 2020 02:18 Inactive
@davejsdev davejsdev changed the base branch from master to davejs/create-configured-resource January 27, 2020 02:20
@davejsdev davejsdev changed the base branch from davejs/create-configured-resource to master January 27, 2020 02:21
@davejsdev davejsdev temporarily deployed to manifold-ui-stage-pr-878 January 27, 2020 13:59 Inactive
@davejsdev davejsdev merged commit 0970663 into master Jan 27, 2020
@davejsdev davejsdev deleted the davejs/resize-resource-features branch January 27, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants