-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(waybar): cliphist only if installed #76
Conversation
The right click parts works but I would have to uninstall cliphist to try the optional part. |
After the purge the cliphist list | wc -l section doesn't seems to update until you restart waybar so it still shows the older amount of items. |
cliphist just added a new commit which will allow us to use rofi to select just 1 item from the list instead of just purging the whole list. While we are doing work on it we might want update it and add the option to delete just 1 item so they can remove password and such without remove the whole list. |
4178d66
to
876e6ce
Compare
On |
well - it is not released yet and I don't know how to properly integrate it into our $clipboard command... I suppose we do that in another PR as soon as it is released
no, |
just did that and works. |
My idea was that we could have a cheap way to run it on logout. But that's not working yet. |
I would move the purge to the middle click on waybar and move the delete item on right click. Wouldn't you want to remove one item more often then deleting everything with everything being remove on startup?
|
so you propose we remove the whole db on startup now and add the single item deletion as soon as that|s released from cliphist side? |
00d486a
to
11917b8
Compare
Wasn't the purging at startup / shutdown one of the items you wanted to add other then making it optional? Or we could just leave the purge on at middle click and add a note like the following to the readme Then we add the remove 1 item after the release. |
11917b8
to
4c642c2
Compare
Should we use $HOME instead of ~? |
ya $HOME works, but probably it does not make a lot of sense as is. |
150e4fe
to
d9ab688
Compare
588911b
to
f93f007
Compare
4640ed2
to
ff747f5
Compare
@Mathew-D I think I found a fine middle ground: you now could opt in to purge on logout by providing |
* feat(waybar): cliphist only if installed * feat: purge cliphist before shutdown * fix: safer check for command * feat: signallify wl-paste watch * fix: remove disfunct shutdown removal * chore: move purge to middle click * feat: purge on reboot and shutdown and logout * feat: introduce variable to purge cliphist on logout
* feat(waybar): cliphist only if installed * feat: purge cliphist before shutdown * fix: safer check for command * feat: signallify wl-paste watch * fix: remove disfunct shutdown removal * chore: move purge to middle click * feat: purge on reboot and shutdown and logout * feat: introduce variable to purge cliphist on logout
* feat(waybar): cliphist only if installed * feat: purge cliphist before shutdown * fix: safer check for command * feat: signallify wl-paste watch * fix: remove disfunct shutdown removal * chore: move purge to middle click * feat: purge on reboot and shutdown and logout * feat: introduce variable to purge cliphist on logout
* feat(waybar): cliphist only if installed * feat: purge cliphist before shutdown * fix: safer check for command * feat: signallify wl-paste watch * fix: remove disfunct shutdown removal * chore: move purge to middle click * feat: purge on reboot and shutdown and logout * feat: introduce variable to purge cliphist on logout
* feat(waybar): cliphist only if installed * feat: purge cliphist before shutdown * fix: safer check for command * feat: signallify wl-paste watch * fix: remove disfunct shutdown removal * chore: move purge to middle click * feat: purge on reboot and shutdown and logout * feat: introduce variable to purge cliphist on logout
* feat(waybar): cliphist only if installed * feat: purge cliphist before shutdown * fix: safer check for command * feat: signallify wl-paste watch * fix: remove disfunct shutdown removal * chore: move purge to middle click * feat: purge on reboot and shutdown and logout * feat: introduce variable to purge cliphist on logout
resolves parts of manjaro-sway/manjaro-sway#175