Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminology and faster assignment #10

Merged
merged 32 commits into from
Jul 23, 2019
Merged

Terminology and faster assignment #10

merged 32 commits into from
Jul 23, 2019

Conversation

RoyalTS
Copy link
Contributor

@RoyalTS RoyalTS commented Jul 23, 2019

As discussed

redouane-dziri and others added 16 commits July 19, 2019 11:02
@redouane-dziri
renamed several variables for more consistency and readability
cc501e1
@redouane-dziri
Merge branch 'master' of github.com:RoyalTS/stochatreat into new-term…
7ab9d55 
…inology
@redouane-dziri
renamed block -> stratum in i/o tests
76b03b3
@redouane-dziri
renamed block -> stratum in stochatreat
08632ab
@redouane-dziri
renamed block -> stratum in assignment tests
253d483
@redouane-dziri
Merge branch 'master' into new-terminology
a7b98d8
@redouane-dziri
new assignment logic adding rows for perfect proportions then deletin…
b7e0a5d 
…g them
@redouane-dziri
replaced len(treat_mask) by denominator for clarity
99672c9
@redouane-dziri
Merge branch 'master' into faster-assignment
6616c13
@redouane-dziri
consistent use of quotation marks
3c0dcc2
@redouane-dziri
consistent drop syntax
95a89da
@redouane-dziri
Merge branch 'faster-assignment' of github.com:RoyalTS/stochatreat in…
fa8d3fe 
…to faster-assignment
@RoyalTS
Merge pull request #16 from RoyalTS/new-terminology
4a0a6bc 
New terminology
@redouane-dziri
merge terminology
15aa9a5
@redouane-dziri
fix random state back
b80d7d4
@RoyalTS
Merge pull request #17 from RoyalTS/faster-assignment
fbcb19f 
Faster assignment with new logic
@RoyalTS RoyalTS changed the title Terminology Terminology and faster assignment Jul 23, 2019
redouane-dziri and others added 13 commits July 23, 2019 10:11
@redouane-dziri
added test for replication with same random_state and shuffled data
3680fcb
@redouane-dziri
add comment to point out that sorting by idx_col is necessary
2467594
@redouane-dziri
Merge branch 'master' of github.com:RoyalTS/stochatreat into random-s…
8cb325f 
…tate
@redouane-dziri
assign stratum_id from the start
e6cc07f
@redouane-dziri
separated tests, one for random_state reproducibility, other for shuf…
a72c339 
…fled data
@redouane-dziri
replaced syntax to build strata list
d3e17a8
@RoyalTS
Merge pull request #19 from RoyalTS/stratum_id
878b646 
Assign stratum_id from the start
@redouane-dziri
modify to respect <80 c line lengths
6eac1c6
@redouane-dziri
deal with no idx_col input
2c624fb
@redouane-dziri
separate check for non duplicates in idx_col
25c58fe
@redouane-dziri
avoid slicing and dicing in sampling
a8c8e7c
@RoyalTS
Merge pull request #21 from RoyalTS/index
fa8bf1a 
Deal with `index_col=None`
@redouane-dziri
removed unnecessary replace=False
cc20597
RoyalTS added 3 commits July 23, 2019 13:58
@RoyalTS
Merge pull request #18 from RoyalTS/random-state
202d7b7 
Added test for replication with same random_state and shuffled data
@RoyalTS
add unit test for sampling size
a001917
@RoyalTS
Merge pull request #22 from RoyalTS/sample
be041a8 
Avoid slicing and dicing in sampling
@manmartgarc manmartgarc merged commit 610546c into manmartgarc:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyalTS @manmartgarc @redouane-dziri